Skip to content

Conversation

tklauser
Copy link
Member

This tests that both L7 redirects (DNS and HTTP) work. The same is already covered in existing Cilium CLI connectivity tests1. Thus this test case is redundant and can be removed.

Suggested-by: @christarazi

For #37838

Footnotes

  1. cilium/cilium-cli/connectivity/builder/manifests/client-egress-to-fqdns.yaml

This tests that both L7 redirects (DNS and HTTP) work. The same is
already covered in existing Cilium CLI connectivity tests[^1]. Thus this
test case is redundant and can be removed.

[^1]: cilium/cilium-cli/connectivity/builder/manifests/client-egress-to-fqdns.yaml

Suggested-by: Chris Tarazi <chris@isovalent.com>
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser requested a review from squeed May 20, 2025 09:50
@tklauser tklauser requested review from a team as code owners May 20, 2025 09:50
@tklauser tklauser added kind/cleanup This includes no functional changes. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. labels May 20, 2025
@tklauser tklauser requested a review from Artyop May 20, 2025 09:50
@tklauser tklauser added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. area/fqdn Affects the FQDN policies feature labels May 20, 2025
@tklauser
Copy link
Member Author

/test

@tklauser tklauser enabled auto-merge May 20, 2025 09:51
@tklauser tklauser added this pull request to the merge queue May 20, 2025
Merged via the queue into main with commit bf09810 May 20, 2025
158 of 167 checks passed
@tklauser tklauser deleted the pr/tklauser/runtime-test-fqdn-migrate branch May 20, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow area/fqdn Affects the FQDN policies feature kind/cleanup This includes no functional changes. release-note/ci This PR makes changes to the CI. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants