Skip to content

Conversation

julianwiedmann
Copy link
Member

Refresh the egressgw documentation to cover kernel-related changes and the recently added IPv6 support.

@julianwiedmann julianwiedmann requested review from a team as code owners May 19, 2025 06:35
@julianwiedmann julianwiedmann added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label May 19, 2025
@julianwiedmann julianwiedmann requested a review from ysksuzuki May 19, 2025 06:35
@julianwiedmann julianwiedmann added release-note/misc This PR makes changes that have no direct user impact. feature/egress-gateway Impacts the egress IP gateway feature. labels May 19, 2025
@julianwiedmann julianwiedmann requested review from qmonnet and rgo3 May 19, 2025 06:35
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann enabled auto-merge May 19, 2025 07:05
Copy link
Contributor

@rgo3 rgo3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the ipv6 changes. Thank you! ❤️

Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: “The first IPv4 and IPv6 address[es]” means two addresses, I'd use the plural form.

Looks good otherwise!

@qmonnet
Copy link
Member

qmonnet commented May 19, 2025

Disabling auto-merge in case you want to fix that nit.

@qmonnet qmonnet disabled auto-merge May 19, 2025 09:15
@julianwiedmann
Copy link
Member Author

Non-blocking: “The first IPv4 and IPv6 address[es]” means two addresses, I'd use the plural form.

Looks good otherwise!

ta! I was tempted to change it, but not 100% certain. Will fix it up along with any feedback by Yusuke.

Copy link
Member

@ysksuzuki ysksuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

With the minimum kernel version requirement now being 5.10, we can trust
that the FIB lookup in the datapath always provides a valid egress ifindex.

Therefore the described fallback situation is no longer relevant, remove
it from the docs.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
We've bumped the miminum kernel version requirement sufficiently so that
version incompatibility with KPR really should no longer be a concern.

So let's not try to list the reasons *why* certain dependencies can not be
enabled, such a description will always go stale.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Reflect cilium#38452 in the docs.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann added this pull request to the merge queue May 20, 2025
Merged via the queue into cilium:main with commit 6cc85db May 20, 2025
63 checks passed
@julianwiedmann julianwiedmann deleted the 1.18-egw-ipv6 branch May 20, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. feature/egress-gateway Impacts the egress IP gateway feature. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants