-
Notifications
You must be signed in to change notification settings - Fork 3.4k
docs: egressgw: various updates #39613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the ipv6 changes. Thank you! ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking: “The first IPv4 and IPv6 address[es]” means two addresses, I'd use the plural form.
Looks good otherwise!
Disabling auto-merge in case you want to fix that nit. |
ta! I was tempted to change it, but not 100% certain. Will fix it up along with any feedback by Yusuke. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
With the minimum kernel version requirement now being 5.10, we can trust that the FIB lookup in the datapath always provides a valid egress ifindex. Therefore the described fallback situation is no longer relevant, remove it from the docs. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
We've bumped the miminum kernel version requirement sufficiently so that version incompatibility with KPR really should no longer be a concern. So let's not try to list the reasons *why* certain dependencies can not be enabled, such a description will always go stale. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Reflect cilium#38452 in the docs. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
ea4c39f
to
d7e69c5
Compare
/test |
Refresh the egressgw documentation to cover kernel-related changes and the recently added IPv6 support.