Skip to content

pkg/health: remove deprecated health metrics #39694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

pkg/health: remove deprecated health metrics #39694

merged 1 commit into from
May 28, 2025

Conversation

jshr-w
Copy link
Contributor

@jshr-w jshr-w commented May 23, 2025

The health metrics node_connectivity_status and node_connectivity_latency_seconds were deprecated with v1.17. This commit removes them.

Deprecated in: #33103

remove deprecated node_connectivity metrics

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 23, 2025
@jshr-w
pkg/health: remove deprecated health metrics
399fe01 
The health metrics `node_connectivity_status` and `node_connectivity_latency_seconds` were deprecated with v1.17. This commit removes them.

Signed-off-by: jshr-w <shjayaraman@microsoft.com>
@jshr-w jshr-w force-pushed the jshr/removedeprecatedhealthmetrics branch from b7c4196 to 399fe01 Compare May 23, 2025 22:16
@jshr-w
Copy link
Contributor Author

jshr-w commented May 27, 2025

/test

@jshr-w jshr-w marked this pull request as ready for review May 27, 2025 18:57
@jshr-w jshr-w requested review from a team as code owners May 27, 2025 18:57
@joestringer joestringer added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label May 28, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 28, 2025
joestringer
joestringer approved these changes May 28, 2025
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@joestringer joestringer enabled auto-merge May 28, 2025 23:10
@joestringer joestringer added this pull request to the merge queue May 28, 2025
Merged via the queue into cilium:main with commit ff6ec70 May 28, 2025
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@thorn3r thorn3r Awaiting requested review from thorn3r thorn3r is a code owner automatically assigned from cilium/sig-agent

@derailed derailed Awaiting requested review from derailed derailed is a code owner automatically assigned from cilium/metrics

Assignees
No one assigned
Labels
release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jshr-w @joestringer