Makefile: Fix creating docker builders #39681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
approved these changes
May 22, 2025
|
Please rebase against the tip of |
|
not sure if it's related to this PR, but the image build failed 👀 https://github.com/cilium/cilium/actions/runs/15190884205/job/42723096009?pr=39681 edit: never mind joe beat me to it #39681 (comment) |
nebril
approved these changes
May 22, 2025
29de690 to
dc57e29
Compare
|
Hmm, no space left on device: https://github.com/cilium/cilium/actions/runs/15191119641/job/42723907246?pr=39681 |
|
I was hoping a rebase would fix that, but apparently not. I filed this issue to investigate: |
It seems that the output of `docker buildx ls` doesn't match the
expectation of the command that we use:
docker buildx ls | grep -E -e "[a-zA-Z0-9-]+ \*" | cut -d ' ' -f1
With the current versions of Docker (28.1.1) and buildx (0.23.0), the
output of `docker buildx ls` looks like this:
NAME/NODE DRIVER/ENDPOINT STATUS BUILDKIT PLATFORMS
naughty_mayer* docker-container
\_ naughty_mayer0 \_ unix:///var/run/docker.sock running v0.21.1 linux/amd64* (+4), linux/arm64*, linux/386
default docker
\_ default \_ default running v0.21.0 linux/amd64 (+4), linux/386
...and the above command's output is empty.
Change the command to the following:
docker buildx ls --format '{{ .Name }}' | head -n1
...assuming that the idea is to get the name of the first builder, check
if it's default (or default-linux), and if it is, create an actual one
that would use the docker-container driver and be able to build
multi-arch images.
This fix resolves the following error message on machines that don't
have a suitable builder in advance:
ERROR: Multi-platform build is not supported for the docker driver.
Switch to a different driver, or turn on the containerd image store, and try again.
Learn more at https://docs.docker.com/go/build-multi-platform/
Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
dc57e29 to
ccff2d6
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the output of
docker buildx lsdoesn't match the expectation of the command that we use:With the current versions of Docker (28.1.1) and buildx (0.23.0), the output of
docker buildx lslooks like this:...and the above command's output is empty.
Change the command to the following:
...assuming that the idea is to get the name of the first builder, check if it's default (or default-linux), and if it is, create an actual one that would use the docker-container driver and be able to build multi-arch images.
This fix resolves the following error message on machines that don't have a suitable builder in advance: