Skip to content

Conversation

joamaki
Copy link
Contributor

@joamaki joamaki commented May 22, 2025

This pulls in the new Hive version that has a safer API for jobs: cilium/hive#51.

Code is fixed as both Hive and StateDB had breaking API changes.

There were no known issues yet with how job.Group was used and this was only discovered in stress testing a new
PR which used the job.Group in a way that caused surprising start up order.

Will do a separate PR for v1.17 regardless to bump to the new versions.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 22, 2025
@github-actions github-actions bot added the sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. label May 22, 2025
This pulls in the new Hive version that has a safer API for jobs:
cilium/hive#51.

Code is fixed as both Hive and StateDB had breaking API changes.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
@joamaki joamaki force-pushed the pr/joamaki/bump-hive-statedb branch from f55207d to 67c0055 Compare May 22, 2025 14:57
@joamaki joamaki added the release-note/misc This PR makes changes that have no direct user impact. label May 22, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 22, 2025
@joamaki
Copy link
Contributor Author

joamaki commented May 22, 2025

/test

@joamaki joamaki marked this pull request as ready for review May 22, 2025 15:18
@joamaki joamaki requested review from a team as code owners May 22, 2025 15:18
@joamaki
Copy link
Contributor Author

joamaki commented May 22, 2025

/test

@joamaki joamaki enabled auto-merge May 23, 2025 08:53
@joamaki joamaki added backport/author The backport will be carried out by the author of the PR. needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels May 23, 2025
@joamaki joamaki added this pull request to the merge queue May 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 25, 2025
@joamaki joamaki added this pull request to the merge queue May 25, 2025
Merged via the queue into cilium:main with commit a719911 May 25, 2025
107 checks passed
@joamaki joamaki deleted the pr/joamaki/bump-hive-statedb branch May 25, 2025 14:24
@aanm
Copy link
Member

aanm commented Aug 13, 2025

@joamaki FYI this PR has not been backported to v1.17 even tho it has the needs-backport/1.17 label.

@joamaki
Copy link
Contributor Author

joamaki commented Aug 15, 2025

@joamaki FYI this PR has not been backported to v1.17 even tho it has the needs-backport/1.17 label.

What do you mean? It was backported in #39689

@joestringer
Copy link
Member

@joamaki above comment is a simple heuristic: The PR has the backport/author label and needs-backport/1.17. Fixing the labels makes it clear that this PR was in fact backported.

@joestringer joestringer added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/author The backport will be carried out by the author of the PR. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants