Skip to content

hubble: Use testing.T.Context added in Go 1.24 in tests #39675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

hubble: Use testing.T.Context added in Go 1.24 in tests #39675

merged 1 commit into from
May 23, 2025

Conversation

HadrienPatte
Copy link
Member

Replace usages of context.TODO() and context.Background() in hubble related packages tests.

Followup of f5d5948 (#38652)

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!
hubble: Use testing.T.Context added in Go 1.24 in tests

@HadrienPatte
hubble: Use testing.T.Context added in Go 1.24 in tests
84a8b76 
Replace usages of `context.TODO()` and `context.Background()` in
hubble related packages tests.

Followup of f5d5948 (cilium#38652)

Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 22, 2025
@github-actions github-actions bot added the hubble-cli PRs or GitHub issues related with hubble-cli label May 22, 2025
@HadrienPatte
Copy link
Member Author

/test

@HadrienPatte HadrienPatte marked this pull request as ready for review May 22, 2025 11:51
@HadrienPatte HadrienPatte requested review from a team as code owners May 22, 2025 11:51
@HadrienPatte HadrienPatte requested a review from glrf May 22, 2025 11:51
glrf
glrf approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@glrf glrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@glrf glrf added the release-note/misc This PR makes changes that have no direct user impact. label May 23, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 23, 2025
@rolinh rolinh added sig/hubble area/hubble Impacts hubble server or relay labels May 23, 2025
rolinh
rolinh approved these changes May 23, 2025
View reviewed changes
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 23, 2025
@tklauser tklauser added this pull request to the merge queue May 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2025
@tklauser tklauser added this pull request to the merge queue May 23, 2025
Merged via the queue into cilium:main with commit 724043c May 23, 2025
73 of 75 checks passed
@HadrienPatte HadrienPatte deleted the hubble-test-context branch May 23, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolinh rolinh rolinh approved these changes

@glrf glrf glrf approved these changes

Assignees
No one assigned
Labels
area/hubble Impacts hubble server or relay hubble-cli PRs or GitHub issues related with hubble-cli ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HadrienPatte @rolinh @glrf @tklauser