Skip to content

helm/hubble: Fix wrong value for metrics server tls existingSecret #39668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

helm/hubble: Fix wrong value for metrics server tls existingSecret #39668

merged 1 commit into from
May 22, 2025

Conversation

devodev
Copy link
Contributor

@devodev devodev commented May 21, 2025 •
edited
Loading

Use hubble.metrics.tls instead of hubble.tls when setting the hubble-metrics-tls projected secret source name in daemonset helm template.

Option added in: 5339161 (PR)

We should label for backport in 1.17.
Thanks!

@devodev
helm/hubble: Fix wrong value for metrics server tls secret
c7dc553 
Use `hubble.metrics.tls` instead of `hubble.tls` when setting the
hubble-metrics-tls projected secret source name in daemonset
helm template.

Signed-off-by: Alexandre Barone <abalexandrebarone@gmail.com>
@devodev devodev requested review from a team as code owners May 21, 2025 22:01
@devodev devodev requested review from joamaki and gandro May 21, 2025 22:01
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 21, 2025
@devodev
Copy link
Contributor Author

devodev commented May 21, 2025

/test

@devodev devodev changed the title helm/hubble: Fix wrong value for metrics server tls secret helm/hubble: Fix wrong value for metrics server tls existingSecret May 21, 2025
@gandro gandro added release-note/bug This PR fixes an issue in a previous release of Cilium. sig/hubble area/helm Impacts helm charts and user deployment experience needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels May 22, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 22, 2025
@gandro gandro added this pull request to the merge queue May 22, 2025
Merged via the queue into cilium:main with commit 51a87eb May 22, 2025
77 checks passed
@joamaki joamaki mentioned this pull request May 23, 2025
Merged
6 tasks
@joamaki joamaki added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels May 23, 2025
@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. labels May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@joamaki joamaki Awaiting requested review from joamaki joamaki is a code owner automatically assigned from cilium/sig-k8s

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devodev @gandro @joamaki