Skip to content

migrate misc packages to slog #39663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

migrate misc packages to slog #39663

merged 1 commit into from
May 23, 2025

Conversation

aanm
Copy link
Member

@aanm aanm commented May 21, 2025

Migrate misc packages to slog

@aanm aanm added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. feature/slog labels May 21, 2025
@aanm
Copy link
Member Author

aanm commented May 21, 2025

/test

@aanm aanm marked this pull request as ready for review May 21, 2025 16:51
@aanm aanm requested review from a team as code owners May 21, 2025 16:51
@aanm aanm requested review from bimmlerd, glrf and tklauser May 21, 2025 16:51
@bimmlerd bimmlerd removed their request for review May 22, 2025 06:34
glrf
glrf approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@glrf glrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter seems unhappy with the imports, but otherwise LGTM

@aanm aanm force-pushed the pr/move-misc-packages-to-slog-4 branch from b577601 to ed09bc4 Compare May 23, 2025 07:43
@aanm aanm enabled auto-merge May 23, 2025 07:43
@aanm
Copy link
Member Author

aanm commented May 23, 2025

/test

@aanm aanm force-pushed the pr/move-misc-packages-to-slog-4 branch from ed09bc4 to f0bd4d1 Compare May 23, 2025 09:02
@aanm
migrate misc packages to slog
db4a7df 
Migrate misc packages to slog

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/move-misc-packages-to-slog-4 branch from f0bd4d1 to db4a7df Compare May 23, 2025 09:03
@aanm
Copy link
Member Author

aanm commented May 23, 2025

/test

@aanm aanm added this pull request to the merge queue May 23, 2025
Merged via the queue into main with commit 4c1d188 May 23, 2025
350 of 351 checks passed
@aanm aanm deleted the pr/move-misc-packages-to-slog-4 branch May 23, 2025 10:26
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@glrf glrf glrf approved these changes

Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. feature/slog ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aanm @tklauser @glrf