Skip to content

add doc for bgp autodiscovery #39645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

add doc for bgp autodiscovery #39645

merged 1 commit into from
May 22, 2025

Conversation

naveenachyuta
Copy link
Contributor

@naveenachyuta naveenachyuta commented May 20, 2025 •
edited
Loading

Fixes: #37315 (add documentation for bgp autodiscovery and DefaultGateway mode)

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Adding documentation for bgp peer auto-discovery and DefaultGateway mode.
bgp peer autodiscovery was added in this PR: #39416

Screenshot of documentation
image

image

docs: Add documentation for BGP Peer Auto-Discovery

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 20, 2025
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label May 20, 2025
@naveenachyuta naveenachyuta force-pushed the bgp_autodiscovery_documentation branch from 0a8b948 to f7cc634 Compare May 20, 2025 17:28
@naveenachyuta naveenachyuta marked this pull request as ready for review May 20, 2025 17:33
@naveenachyuta naveenachyuta requested review from a team as code owners May 20, 2025 17:33
@naveenachyuta naveenachyuta force-pushed the bgp_autodiscovery_documentation branch from f7cc634 to 21dadfb Compare May 20, 2025 17:52
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label May 20, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 20, 2025
qmonnet
qmonnet requested changes May 21, 2025
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Please find some style nitpicks below.

Regarding your commit description:

Fixes: 37315

Please use a # to refer to the PR (Fixes: #37315), this way GitHub will be able to create the link to the issue.

@naveenachyuta
add doc for bgp autodiscovery
edb3295 
Fixes: cilium#37315 (add documentation for bgp autodiscovery and DefaultGateway mode)
Signed-off-by: Naveen Achyuta <naveen.achyuta22@gmail.com>
@naveenachyuta naveenachyuta force-pushed the bgp_autodiscovery_documentation branch from d07fc10 to edb3295 Compare May 22, 2025 04:31
@naveenachyuta
Copy link
Contributor Author

naveenachyuta commented May 22, 2025 •
edited
Loading

@qmonnet added all the suggestions and fixed commit description. updated PR description with new screenshots

@naveenachyuta naveenachyuta requested a review from qmonnet May 22, 2025 04:36
qmonnet
qmonnet approved these changes May 22, 2025
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@qmonnet
Copy link
Member

qmonnet commented May 22, 2025

/test

@qmonnet qmonnet added the area/bgp Impacts the Border Gateway Protocol feature. label May 22, 2025
@qmonnet qmonnet added this pull request to the merge queue May 22, 2025
Merged via the queue into cilium:main with commit cb766ae May 22, 2025
65 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

@harsimran-pabla harsimran-pabla harsimran-pabla approved these changes

Assignees
No one assigned
Labels
area/bgp Impacts the Border Gateway Protocol feature. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CFP: Auto Peer Discovery for Cilium BGP
4 participants
@naveenachyuta @qmonnet @harsimran-pabla @joestringer