Skip to content

Move metrics to slog #39537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2025
Merged

Move metrics to slog #39537

merged 2 commits into from
May 30, 2025

Conversation

aanm
Copy link
Member

@aanm aanm commented May 14, 2025 •
edited
Loading

No description provided.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 14, 2025
@github-actions github-actions bot added the sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. label May 14, 2025
@aanm aanm added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. feature/slog labels May 14, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 14, 2025
tommyp1ckles
tommyp1ckles reviewed May 14, 2025
View reviewed changes
@aanm aanm force-pushed the pr/move-metrics-to-slog branch from 3d844c2 to a97bacb Compare May 16, 2025 09:18
@aanm aanm requested review from tommyp1ckles and joamaki May 16, 2025 09:18
@aanm
Copy link
Member Author

aanm commented May 16, 2025

/test

@aanm aanm force-pushed the pr/move-metrics-to-slog branch from a97bacb to 700a61c Compare May 16, 2025 10:05
@aanm
Copy link
Member Author

aanm commented May 16, 2025

/test

@aanm aanm added the area/metrics Impacts statistics / metrics gathering, eg via Prometheus. label May 16, 2025
@aanm aanm force-pushed the pr/move-metrics-to-slog branch from 700a61c to 3488edf Compare May 16, 2025 10:53
@aanm
Copy link
Member Author

aanm commented May 16, 2025

/test

@aanm
Copy link
Member Author

aanm commented May 16, 2025

The CI failures are fixed in #39578

@aanm aanm marked this pull request as ready for review May 16, 2025 12:20
@aanm aanm requested review from a team as code owners May 16, 2025 12:20
@aanm aanm requested review from Artyop, ti-mo and youngnick May 16, 2025 12:20
@aanm aanm enabled auto-merge May 16, 2025 12:20
@aanm aanm force-pushed the pr/move-metrics-to-slog branch from 3488edf to 869d626 Compare May 19, 2025 13:07
@aanm
Copy link
Member Author

aanm commented May 19, 2025

/test

@aanm
Copy link
Member Author

aanm commented May 19, 2025

/test

@aanm aanm force-pushed the pr/move-metrics-to-slog branch from 869d626 to c29a13c Compare May 21, 2025 07:13
@aanm
Copy link
Member Author

aanm commented May 21, 2025

/test

@aanm
Copy link
Member Author

aanm commented May 23, 2025

@ti-mo can you take a look? Thanks!

aanm added 2 commits May 23, 2025 11:34
@aanm
pkg/metrics: migrate to slog
7cb7972 
Migrate this package to use slog instead of logrus.

Signed-off-by: André Martins <andre@cilium.io>
@aanm
pkg/metrics: enable invalid label values detector in CI
3b648bf 
Since we are going to panic in the CI every time a label has an unknown
value we should fix existing labels that have unknown values.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/move-metrics-to-slog branch from c29a13c to 3b648bf Compare May 23, 2025 09:36
@aanm
Copy link
Member Author

aanm commented May 23, 2025

/test

tommyp1ckles
tommyp1ckles approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor

@tommyp1ckles tommyp1ckles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks!

@aanm aanm added this pull request to the merge queue May 30, 2025
Merged via the queue into main with commit 3833656 May 30, 2025
295 of 296 checks passed
@aanm aanm deleted the pr/move-metrics-to-slog branch May 30, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joamaki joamaki joamaki approved these changes

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

@youngnick youngnick youngnick approved these changes

@Artyop Artyop Artyop approved these changes

@ti-mo ti-mo Awaiting requested review from ti-mo ti-mo was automatically assigned from cilium/loader

+1 more reviewer

@doniacld doniacld doniacld approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/metrics Impacts statistics / metrics gathering, eg via Prometheus. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. feature/slog release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aanm @joamaki @tommyp1ckles @youngnick @Artyop @doniacld