-
Notifications
You must be signed in to change notification settings - Fork 3.4k
loadbalancer: Port forwarding mode to new control-plane #39534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, so much less code compared to the old control plane 🚀
3b6aff2
to
854f6fc
Compare
/test |
854f6fc
to
72d3b78
Compare
Move the load-balancer mode related configuration options into the loadbalancer config. The LoadBalancerDSRDispatch validation is commented out, but will be fixed in next commit. Signed-off-by: Jussi Maki <jussi@isovalent.com>
This moves the LoadBalancerDSRDispatch to loadbalancer.Config. Signed-off-by: Jussi Maki <jussi@isovalent.com>
This ports the service forwarding mode annotation to the new control-plane (cilium#35064). Signed-off-by: Jussi Maki <jussi@isovalent.com>
72d3b78
to
d9dd92b
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cilium/metrics lgtm
This ports the service forwarding mode annotation to the new control-plane (#35064).
To simplify the implementation and testing I'm first moving the related configuration options to
loadbalancer.Config
.