Skip to content

loadbalancer: Port forwarding mode to new control-plane #39534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025

Conversation

joamaki
Copy link
Contributor

@joamaki joamaki commented May 14, 2025

This ports the service forwarding mode annotation to the new control-plane (#35064).

To simplify the implementation and testing I'm first moving the related configuration options to loadbalancer.Config.

@joamaki joamaki requested a review from borkmann May 14, 2025 13:58
@joamaki joamaki added the release-note/misc This PR makes changes that have no direct user impact. label May 14, 2025
@joamaki

This comment was marked as outdated.

Copy link
Member

@borkmann borkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, so much less code compared to the old control plane 🚀

@joamaki joamaki force-pushed the pr/joamaki/lb-svc-fwd-mode branch 2 times, most recently from 3b6aff2 to 854f6fc Compare May 14, 2025 15:48
@joamaki
Copy link
Contributor Author

joamaki commented May 14, 2025

/test

@joamaki joamaki marked this pull request as ready for review May 14, 2025 16:13
@joamaki joamaki requested review from a team as code owners May 14, 2025 16:13
@joamaki joamaki requested review from thorn3r, tklauser, tommyp1ckles, aditighag and ti-mo and removed request for aditighag May 14, 2025 16:13
@joamaki joamaki force-pushed the pr/joamaki/lb-svc-fwd-mode branch from 854f6fc to 72d3b78 Compare May 15, 2025 12:02
joamaki added 3 commits May 19, 2025 10:30
Move the load-balancer mode related configuration options into
the loadbalancer config. The LoadBalancerDSRDispatch validation
is commented out, but will be fixed in next commit.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
This moves the LoadBalancerDSRDispatch to loadbalancer.Config.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
This ports the service forwarding mode annotation to the new control-plane
(cilium#35064).

Signed-off-by: Jussi Maki <jussi@isovalent.com>
@joamaki joamaki force-pushed the pr/joamaki/lb-svc-fwd-mode branch from 72d3b78 to d9dd92b Compare May 19, 2025 08:35
@joamaki
Copy link
Contributor Author

joamaki commented May 19, 2025

/test

@joamaki joamaki enabled auto-merge May 19, 2025 09:18
Copy link
Contributor

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@thorn3r thorn3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent 🚢

Copy link
Contributor

@tommyp1ckles tommyp1ckles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cilium/metrics lgtm

@joamaki joamaki added this pull request to the merge queue May 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 21, 2025
@joamaki joamaki added this pull request to the merge queue May 21, 2025
Merged via the queue into cilium:main with commit b4f9d17 May 21, 2025
67 checks passed
@joamaki joamaki deleted the pr/joamaki/lb-svc-fwd-mode branch May 21, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants