Skip to content

loadbalancer: Port SourceRangesPolicy annotation to new control-plane #39533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

loadbalancer: Port SourceRangesPolicy annotation to new control-plane #39533

merged 1 commit into from
May 19, 2025
+48 −0

Conversation

joamaki
Copy link
Contributor

@joamaki joamaki commented May 14, 2025

This ports #36120 to the new control-plane.

@joamaki joamaki requested a review from borkmann May 14, 2025 13:41
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 14, 2025
@joamaki joamaki added release-note/misc This PR makes changes that have no direct user impact. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 14, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 14, 2025
borkmann
borkmann approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@borkmann borkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, could we also do one test with SourceRangesPolicy=allow as annotation?

@joamaki
Copy link
Contributor Author

joamaki commented May 14, 2025

lgtm, could we also do one test with SourceRangesPolicy=allow as annotation?

Sure thing, will add it.

@joamaki joamaki force-pushed the pr/joamaki/lb-source-ranges-policy branch from d7f76dd to 27ca7f4 Compare May 14, 2025 15:11
@joamaki joamaki marked this pull request as ready for review May 14, 2025 15:11
@joamaki joamaki requested a review from a team as a code owner May 14, 2025 15:11
@joamaki joamaki requested review from aditighag and removed request for aditighag May 14, 2025 15:11
@joamaki
Copy link
Contributor Author

joamaki commented May 14, 2025

/test

@joamaki joamaki enabled auto-merge May 14, 2025 15:12
@joamaki
loadbalancer: Port SourceRangesPolicy annotation to new control-plane
d310b0b 
This ports cilium#36120 to the new control-plane.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
@joamaki joamaki force-pushed the pr/joamaki/lb-source-ranges-policy branch from 27ca7f4 to d310b0b Compare May 19, 2025 08:26
@joamaki
Copy link
Contributor Author

joamaki commented May 19, 2025

/test

@joamaki joamaki added this pull request to the merge queue May 19, 2025
Merged via the queue into cilium:main with commit 98db769 May 19, 2025
69 of 78 checks passed
@joamaki joamaki deleted the pr/joamaki/lb-source-ranges-policy branch May 19, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joamaki @borkmann