Revert "Disable GitHub workflows on forks" #39529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e0d963d. Reverting, because the referenced commit is being reverted as well. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
…able kill switch" This reverts commit a4b295c. This commit turned out having unexpected effects also on PRs against cilium/cilium when opened from a fork, with certain tests being incorrectly skipped. Most likely, because the ENABLE_CILIUM_CI var is attempted to be directly read from repository hosting the branch, rather than the target repository, in case of pull_request workflows. Hence, let's revert it for the moment to restore the execution of all tests. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
|
/test |
|
The Check Patch failure is: Which I think is acceptable in this context, given that the title is generated from the reverted one. The original commit was also already not respecting that rule, but got missed because the test got skipped in that PR as well. |
|
cc @ishuar FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#38791 turned out having unexpected effects also on PRs against cilium/cilium when opened from a fork, with certain tests being incorrectly skipped. Most likely, because the ENABLE_CILIUM_CI var is attempted to be directly read from repository hosting the branch, rather than the target repository, in case of pull_request workflows.
Hence, let's revert it for the moment to restore the execution of all tests.
Additionally reverting #39392, which was a follow-up fix.