-
Notifications
You must be signed in to change notification settings - Fork 3.4k
datapath: strictly require even more BPF functionality #39524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test |
197a37a
to
35c461c
Compare
/test |
dylandreimerink
approved these changes
May 19, 2025
@julianwiedmann looks like this picked up a merge conflict |
yep, will address it along with any other feedback by @tommyp1ckles |
35c461c
to
4771844
Compare
With 58b6a70 ("datapath: require HAVE_NETNS_COOKIE") we're now probing for these helpers on startup, and can stop doing so in feature-specific code paths. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
The corresponding helper is available as of kernel v5.8, and thus covered by our new v5.10 requirement. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
4771844
to
6766afe
Compare
/test |
@cilium/sig-k8s looks like Tom is busy, could maybe someone else have a quick look at this PR? :) |
marseel
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/datapath
Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
area/kernel
Requires upstream work in the Linux kernel.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #38308 and #39384, clean up a bit more BPF feature probing code.