Skip to content

datapath: strictly require even more BPF functionality #39524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025

Conversation

julianwiedmann
Copy link
Member

@julianwiedmann julianwiedmann commented May 14, 2025

Continuing from #38308 and #39384, clean up a bit more BPF feature probing code.

@julianwiedmann julianwiedmann added area/kernel Requires upstream work in the Linux kernel. area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels May 14, 2025
@julianwiedmann julianwiedmann changed the title Pr/jwi/main/more feature probes datapath: strictly require even more BPF functionality May 14, 2025
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann force-pushed the pr/jwi/main/more-feature-probes branch from 197a37a to 35c461c Compare May 14, 2025 07:46
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann marked this pull request as ready for review May 14, 2025 09:29
@julianwiedmann julianwiedmann requested review from a team as code owners May 14, 2025 09:29
@julianwiedmann julianwiedmann enabled auto-merge May 14, 2025 09:29
@tklauser tklauser added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label May 21, 2025
@tklauser
Copy link
Member

@julianwiedmann looks like this picked up a merge conflict

@julianwiedmann
Copy link
Member Author

@julianwiedmann looks like this picked up a merge conflict

yep, will address it along with any other feedback by @tommyp1ckles

@julianwiedmann julianwiedmann force-pushed the pr/jwi/main/more-feature-probes branch from 35c461c to 4771844 Compare May 27, 2025 12:30
@julianwiedmann julianwiedmann removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label May 27, 2025
With 58b6a70 ("datapath: require HAVE_NETNS_COOKIE") we're now
probing for these helpers on startup, and can stop doing so in
feature-specific code paths.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
The corresponding helper is available as of kernel v5.8, and thus covered
by our new v5.10 requirement.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann force-pushed the pr/jwi/main/more-feature-probes branch from 4771844 to 6766afe Compare May 27, 2025 14:44
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann
Copy link
Member Author

@cilium/sig-k8s looks like Tom is busy, could maybe someone else have a quick look at this PR? :)

@julianwiedmann julianwiedmann added this pull request to the merge queue May 29, 2025
Merged via the queue into main with commit ac039d1 May 29, 2025
300 of 308 checks passed
@julianwiedmann julianwiedmann deleted the pr/jwi/main/more-feature-probes branch May 29, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/kernel Requires upstream work in the Linux kernel. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants