helm: possibility to use kvstoremesh in kvstore identity allocation mode #39523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
giorio94
reviewed
May 14, 2025
There was a problem hiding this comment.
Thanks! I've left a couple of initial comments inline, but overall looks good to me. The failure in https://github.com/cilium/cilium/actions/runs/15013707530/job/42186994377?pr=39523 is also legitimate.
I'll perform the final tests + review once the other PR gets merged.
install/kubernetes/cilium/templates/clustermesh-apiserver/clusterrole.yaml
Outdated
Show resolved
Hide resolved
c54c562 to
f0f3ef5
Compare
|
/test |
giorio94
approved these changes
May 20, 2025
gandro
approved these changes
May 20, 2025
|
/test |
|
@balous Could you please squash the two commits together? I'll retrigger the tests afterwards. |
The apiserver than omits 'apiserver' container but retains 'kvstoremesh' and 'etcd'. This combo than acts as caching etcd for the rest of the clustermesh. Signed-off-by: Petr Baloun <petr.baloun@firma.seznam.cz>
Squashed. |
|
/test |
tommyp1ckles
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements possibility to run
clustermesh-apiserverwithkvstoreidentity allocation mode. In this scenario, theclustermesh-apiserverdeployment omitsapiservercontainer but retainskvstoremeshandetcdcontainers. Resulting combo than acts as a cache for the data of other clusters in the mesh.clustermesh-apiserverdeployment implements a scalable, high availability etcd storage without need to set up and maintain an external etcd cluster. This PR implements easy way to use it for clusters withkvstoreidentity allocation mode.This setup was allowed by implementing (optional) heartbeat in
kvstoremeshcontainer.Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.