Skip to content

kvstoremesh: possibility to enable kvstore heartbeat #39521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

kvstoremesh: possibility to enable kvstore heartbeat #39521

merged 1 commit into from
May 15, 2025

Conversation

balous
Copy link
Contributor

@balous balous commented May 14, 2025

With etcd in external mode the apiserver is not running. This PR implements optional heartbeat in kvstoremesh.

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin

Fixes: #39356

@balous balous requested review from a team as code owners May 14, 2025 05:53
@balous balous requested a review from giorio94 May 14, 2025 05:53
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 14, 2025
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label May 14, 2025
@balous balous mentioned this pull request May 14, 2025
Closed
3 tasks
giorio94
giorio94 approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The overall approach looks good to me.

Could you please address the linter errors? I'll trigger the tests afterwards.

@giorio94 giorio94 added area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/misc This PR makes changes that have no direct user impact. labels May 14, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 14, 2025
@balous balous changed the title kvstoremesh: possibility to enable kvstore heartbeat draft: kvstoremesh: possibility to enable kvstore heartbeat May 14, 2025
@balous balous marked this pull request as draft May 14, 2025 08:52
@balous balous force-pushed the kvstoremesh-heartbeat branch 2 times, most recently from b6da0a5 to acabb6f Compare May 15, 2025 04:43
@balous balous changed the title draft: kvstoremesh: possibility to enable kvstore heartbeat kvstoremesh: possibility to enable kvstore heartbeat May 15, 2025
@balous balous marked this pull request as ready for review May 15, 2025 05:21
@balous
kvstoremesh: possibility to enable kvstore heartbeat
093f44d 
With etcd in external mode the apiserver is not running. This commit implements optional heartbeat in kvstoremesh.

Fixes: cilium#39356
Signed-off-by: Petr Baloun <petr.baloun@firma.seznam.cz>
@balous balous force-pushed the kvstoremesh-heartbeat branch from acabb6f to 093f44d Compare May 15, 2025 05:27
@giorio94
Copy link
Member

/test

@giorio94 giorio94 enabled auto-merge May 15, 2025 06:59
@balous
Copy link
Contributor Author

balous commented May 15, 2025 •
edited
Loading

/test

Is the failed test reliable? I tried to rerun the tests here at my computer for several times and it failed just once - for the first time :-).

@giorio94
Copy link
Member

/test

Is the failed test reliable? I tried to rerun the tests here at my computer for several times and it failed just once - for the first time :-).

They hit a flake. I've restarted them, hopefully they pass now.

@giorio94 giorio94 added this pull request to the merge queue May 15, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 15, 2025
Merged via the queue into cilium:main with commit b021f91 May 15, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giorio94 giorio94 giorio94 approved these changes

Assignees
No one assigned
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kvstoremesh heartbeat with external etcd
2 participants
@balous @giorio94