HELM: Adding Label Support to clustermesh apiserver service #39520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
8a965dd to
a278371
Compare
This comment was marked as resolved.
This comment was marked as resolved.
a278371 to
52f9406
Compare
52f9406 to
21f257e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
21f257e to
cfc23e9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
cfc23e9 to
300f7c6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
300f7c6 to
f03fe30
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Camillo Rossi <camrossi@cisco.com>
f03fe30 to
8275f1b
Compare
|
/test |
gandro
approved these changes
May 14, 2025
|
Marked for backport to 1.17, as potentially useful, and it should come at no risk. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #39488
Add Labels support to the
clustermesh apiserver serviceThis is required if service mesh is deployed on Cilium Clusters that are advertising services via BGP.
A service is selected to be advertised by a
selectorfield that is a label selector matching on the service.Without this config it is impossible to have the clustermesh apiserver service advertised via BGP.