plugins: Don't install CNI conf in container image #39516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
squeed
approved these changes
May 26, 2025
|
Huh, yeah I guess with the |
0dd0f8f to
422482b
Compare
|
/test |
I noticed in local testing that when you deploy Cilium with a custom CNI configuration, Cilium may report a different CNI configuration file inside the Cilium container compared with the configuration on the underlying host despite mapping the host filesystem into the Cilium container. This appears to be due to the use of overlayfs and because the 'install' target (invoked during container build) installs this config file into the filesystem of the container itself. This ultimately obscures the true config when inspecting it from inside the Cilium container. Remove the extra unneeded config file to reduce confusion. Signed-off-by: Joe Stringer <joe@cilium.io>
422482b to
9404674
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in local testing that when you deploy Cilium with a custom CNI
configuration, Cilium may report a different CNI configuration file
inside the Cilium container compared with the configuration on the
underlying host despite mapping the host filesystem into the Cilium
container. This appears to be due to the use of overlayfs and because
the 'install' target (invoked during container build) installs this
config file into the filesystem of the container itself. This ultimately
obscures the true config when inspecting it from inside the Cilium
container. Remove the extra unneeded config file to reduce confusion.