ipsec: Fix key count in key rotation test #39512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70210e1 to
1f8cba8
Compare
The GitHub action to perform IPsec key rotations expect a parameter nb-nodes, described as "Number of nodes in the cluster or clustermesh". The value actually expected is however the number of *remote nodes*, so the number of nodes minus one. Let's fix this to match the description. We'll decrement the value in the GitHub action. Reported-by: Viktor Kurchenko <viktor.kurchenko@isovalent.com> Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
During the key rotation test, we count the number of IPsec keys to determine where we are in the key rotation. That number however depends on the IPAM mode. Indeed, for ENI and Azure IPAM modes, we install two XFRM states on ingress instead of one, each with their own IPsec key. This commit therefore adds support for these mode, called subnet encryption in the context of IPsec. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
1f8cba8 to
6bb7ac5
Compare
Artyop
approved these changes
May 14, 2025
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viktor noticed that the
nb-nodesparameter for the IPsec key rotation tests wasn't consistent with the actual number of nodes in the test clusters. This pull request fixes it. It turns out the tests were passing for the wrong reasons. See commits for details.