bpf/lib/lb.h: Fix active connection tracking + IPv6 #39509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci-verifier |
During some other work I discovered that the whole active connection tracking feature does not compile when enabled. Adding to the complexity tests to add some compile coverage as regression test. Will fix the actual issue in a subsequent commit. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
When both IPv6 and active connection tracking are enabled, we are unable to compile, resulting in the following error: ``` ./lib/lb.h:1071:21: error: use of undeclared identifier 'ct_state' ``` This is because in `lb6_local` the name of the variable is `state` not `ct_state`. This issue seems to have been here since the introduction of the feature and was never caught due to a lack of testing. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
42f14ae to
ee5cb29
Compare
gentoo-root
approved these changes
May 13, 2025
|
/test |
5 tasks
9 tasks
pchaigno
reviewed
Aug 19, 2025
| @@ -42,3 +42,4 @@ | |||
| -DENABLE_EGRESS_GATEWAY=1 | |||
| -DSERVICE_NO_BACKEND_RESPONSE=1 | |||
| -DTRACE_NOTIFY=1 | |||
| -DENABLE_ACTIVE_CONNECTION_TRACKING=1 | |||
There was a problem hiding this comment.
During some other work I discovered that the whole active connection
tracking feature does not compile when enabled. Adding to the complexity
tests to add some compile coverage as regression test.
Note complexity tests are different from compile tests. Compile tests are contained in bpf/Makefile, rather cheap, and covering various arbitrary combinations of options. These are complexity tests are should attempt to maximize complexity. Hence, this macro should also be added to bpf/Makefile and it should probably be in every single complexity test file given it seems likely to only increase complexity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some other work I discovered that the whole active connection tracking feature does not compile when enabled in combination with IPv6.
When both IPv6 and active connection tracking are enabled, we are unable to compile, resulting in the following error:
This is because in
lb6_localthe name of the variable isstatenotct_state. This issue seems to have been here since the introduction of the feature and was never caught due to a lack of testing.Also adding to the complexity tests to add some compile coverage as regression test.