Skip to content

docs: Revert incompatibility note with Istio #39503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

docs: Revert incompatibility note with Istio #39503

merged 1 commit into from
May 15, 2025

Conversation

aditighag
Copy link
Member

Context - #38338.

@aditighag
docs: Revert incompatibility note with Istio
bff2f02 
Context - cilium#38338.

Signed-off-by: Aditi Ghag <aditi@cilium.io>
@aditighag aditighag requested review from a team as code owners May 12, 2025 21:14
@aditighag aditighag added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label May 12, 2025
@aditighag aditighag requested a review from YutaroHayakawa May 12, 2025 21:14
@aditighag aditighag added the release-note/misc This PR makes changes that have no direct user impact. label May 12, 2025
@aditighag aditighag requested a review from qmonnet May 12, 2025 21:14
@aditighag
Copy link
Member Author

Wow — what a coincidence that the same set of people from the linked PR have been selected as reviewers here! 😄

@aditighag
Copy link
Member Author

/test

qmonnet
qmonnet approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! 🙂

The change looks OK but the context in the linked PR doesn't explain why the note can be removed (or, I missed it). Is masquerading now compatible with Istio?

@aditighag
Copy link
Member Author

See this comment - #38338 (comment).

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 14, 2025
@qmonnet
Copy link
Member

qmonnet commented May 15, 2025

OK thank you

@qmonnet qmonnet added this pull request to the merge queue May 15, 2025
Merged via the queue into cilium:main with commit 72465ef May 15, 2025
72 checks passed
@aditighag aditighag deleted the pr/aditighag/revert-bpf-masq-istio-note branch May 15, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aditighag @qmonnet @YutaroHayakawa