Skip to content

pkg/option: migrate to slog #39502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

pkg/option: migrate to slog #39502

merged 1 commit into from
May 15, 2025

Conversation

aanm
Copy link
Member

@aanm aanm commented May 12, 2025

Migrate this package to use slog instead of logrus.

@aanm aanm added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. feature/slog labels May 12, 2025
@aanm
Copy link
Member Author

aanm commented May 12, 2025

/test

@aanm aanm force-pushed the pr/move-option-to-slog branch from acba7ef to 5bdb8c5 Compare May 12, 2025 16:26
@aanm
Copy link
Member Author

aanm commented May 12, 2025

/test

@aanm aanm marked this pull request as ready for review May 12, 2025 16:26
@aanm aanm requested review from a team as code owners May 12, 2025 16:26
@aanm aanm enabled auto-merge May 12, 2025 16:26
@aanm aanm force-pushed the pr/move-option-to-slog branch from 5bdb8c5 to da15c2b Compare May 13, 2025 07:07
@aanm
Copy link
Member Author

aanm commented May 13, 2025

/test

pippolo84
pippolo84 reviewed May 13, 2025
View reviewed changes
@aanm aanm force-pushed the pr/move-option-to-slog branch from da15c2b to ec27828 Compare May 14, 2025 07:25
@aanm
Copy link
Member Author

aanm commented May 14, 2025

/test

@aanm aanm requested a review from pippolo84 May 14, 2025 07:25
pippolo84
pippolo84 approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@pippolo84 pippolo84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 15, 2025
@aanm
pkg/option: migrate to slog
97f7275 
Migrate this package to use slog instead of logrus.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/move-option-to-slog branch from ec27828 to 97f7275 Compare May 15, 2025 07:57
@aanm
Copy link
Member Author

aanm commented May 15, 2025

/test

@aanm aanm added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit 48c1028 May 15, 2025
279 checks passed
@aanm aanm deleted the pr/move-option-to-slog branch May 15, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

@pippolo84 pippolo84 pippolo84 approved these changes

@Artyop Artyop Artyop approved these changes

@aditighag aditighag aditighag approved these changes

@thorn3r thorn3r thorn3r approved these changes

Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. feature/slog ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aanm @derailed @pippolo84 @Artyop @aditighag @thorn3r