Skip to content

Deprecate --enable-recorder #39585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

Deprecate --enable-recorder #39585

merged 1 commit into from
May 20, 2025

Conversation

brb
Copy link
Member

@brb brb commented May 16, 2025 •
edited
Loading

Also known as PCAP recorder. It's no longer maintained.

cc @gandro

@brb
Deprecate --enable-recorder
2955399 
Also known as PCAP recorder.

Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
@brb brb added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/agent Cilium agent related. area/loadbalancing Impacts load-balancing and Kubernetes service implementations labels May 16, 2025
@brb brb mentioned this pull request May 16, 2025
Closed
@brb brb added the area/hubble Impacts hubble server or relay label May 16, 2025
@brb
Copy link
Member Author

brb commented May 16, 2025

/test

@brb brb marked this pull request as ready for review May 16, 2025 18:12
@brb brb requested review from a team as code owners May 16, 2025 18:12
@brb brb requested review from qmonnet, thorn3r and gandro May 16, 2025 18:12
gandro
gandro reviewed May 20, 2025
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Should we also mark related flags (enable-hubble-recorder-api, hubble-recorder-*) as deprecated?

@brb
Copy link
Member Author

brb commented May 20, 2025

Should we also mark related flags (enable-hubble-recorder-api, hubble-recorder-*) as deprecated?

Good question. I think it's enough to deprecate only enable-recorder, as enable-hubble-recorder-api and hubble-recorder-* are noop, if enable-recorder is disabled.

@brb brb requested a review from gandro May 20, 2025 13:23
@brb brb added this pull request to the merge queue May 20, 2025
Merged via the queue into main with commit 08c6311 May 20, 2025
353 of 362 checks passed
@brb brb deleted the pr/brb/depreace-pcap-recorder branch May 20, 2025 13:46
@qmonnet
Copy link
Member

qmonnet commented May 20, 2025

Good question. I think it's enough to deprecate only enable-recorder, as enable-hubble-recorder-api and hubble-recorder-* are noop, if enable-recorder is disabled.

@brb Not sure I understand, if they become no-op why not deprecate these flags as well, so we can remove them all together in 1.19?

@brb
Copy link
Member Author

brb commented May 20, 2025

@qmo My thinking is that the enable-recorder deprecation implies the deprecation of the other flags. But let's be explicit, I will file a new PR.

@brb
Copy link
Member Author

brb commented May 20, 2025

@qmo #39642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@qmonnet qmonnet qmonnet approved these changes

@thorn3r thorn3r Awaiting requested review from thorn3r thorn3r is a code owner automatically assigned from cilium/sig-agent

Assignees
No one assigned
Labels
area/agent Cilium agent related. area/hubble Impacts hubble server or relay area/loadbalancing Impacts load-balancing and Kubernetes service implementations release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brb @qmonnet @gandro