-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Deprecate enable-{node-port,host-port,externalips} #39581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2113ce3
to
06b25d7
Compare
da08677
to
ba48e3c
Compare
/test |
ba48e3c
to
84f06cd
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good, thanks.
What's the motivation for dropping the individual flags?
Good question - we want to simplify UX for KPR users. Currently, the whole configuration is quite puzzling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
They will be unconditionally enabled with --kpr=true in v1.19. Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
84f06cd
to
ccafd04
Compare
/test |
... and enable them unconditionally when
--kube-proxy-replacement=true
.