Skip to content

Deprecate enable-{node-port,host-port,externalips} #39581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2025

Conversation

brb
Copy link
Member

@brb brb commented May 16, 2025

... and enable them unconditionally when --kube-proxy-replacement=true.

@brb brb added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/loadbalancing Impacts load-balancing and Kubernetes service implementations labels May 16, 2025
@brb brb force-pushed the pr/brb/deprecate-kpr-subflags branch from 2113ce3 to 06b25d7 Compare May 16, 2025 14:02
@brb brb changed the title Deprecate enable-{nodeport,hostport,externalips} Deprecate enable-{node-port,host-port,externalips} May 16, 2025
@brb brb force-pushed the pr/brb/deprecate-kpr-subflags branch from da08677 to ba48e3c Compare May 16, 2025 14:26
@brb
Copy link
Member Author

brb commented May 16, 2025

/test

@brb brb force-pushed the pr/brb/deprecate-kpr-subflags branch from ba48e3c to 84f06cd Compare May 16, 2025 14:48
@brb
Copy link
Member Author

brb commented May 16, 2025

/test

@brb brb marked this pull request as ready for review May 16, 2025 18:11
@brb brb requested review from a team as code owners May 16, 2025 18:11
@brb brb requested review from ysksuzuki, qmonnet and thorn3r May 16, 2025 18:11
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, thanks.

What's the motivation for dropping the individual flags?

@brb
Copy link
Member Author

brb commented May 19, 2025

What's the motivation for dropping the individual flags?

Good question - we want to simplify UX for KPR users. Currently, the whole configuration is quite puzzling.

Copy link
Member

@ysksuzuki ysksuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brb brb enabled auto-merge May 20, 2025 05:27
brb added 3 commits May 20, 2025 16:41
They will be unconditionally enabled with --kpr=true in v1.19.

Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
@brb brb force-pushed the pr/brb/deprecate-kpr-subflags branch from 84f06cd to ccafd04 Compare May 20, 2025 14:41
@brb
Copy link
Member Author

brb commented May 20, 2025

/test

@brb brb added this pull request to the merge queue May 20, 2025
Merged via the queue into main with commit 9fbf4c7 May 20, 2025
298 of 300 checks passed
@brb brb deleted the pr/brb/deprecate-kpr-subflags branch May 20, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/loadbalancing Impacts load-balancing and Kubernetes service implementations release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants