Skip to content

v1.17 Backports 2025-05-15 #39564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 19, 2025
Merged

Conversation

foyerunix and others added 10 commits May 15, 2025 18:38
[ upstream commit d3c80fa ]

Add a check for services whose protocol is "ANY" to close their UDP
connections too.

Fixes: #37577

Signed-off-by: foyerunix <foyerunix@foyer.lu>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
[ upstream commit d70929b ]

The BPF_HAVE_NETNS_COOKIE macro doesn't exist in-tree, use the correct
spelling.

Looks like the PR that introduced this test conflicted with the renaming in
17a652b ("probes: remove 'BPF_' prefix from features macros").

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
[ upstream commit 1276096 ]

Add a section to talk about the native routing masquerading in the cloud
environment based on discussion
#39156 (comment)

Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
[ upstream commit 6fbc035 ]

Signed-off-by: Camillo Rossi <camrossi@cisco.com>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
[ upstream commit 3a59bed ]

Setting both IDs and a maxresult parameter in a describe call input is
not possible, see [AWS documentation](https://docs.aws.amazon.com/AWSEC2/latest/APIReference/Query-Requests.html#api-pagination):

> If you call a describe API action with both a list of IDs and MaxResults, the request fails with the error InvalidParameterCombination.

Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
[ upstream commit 3fb8618 ]

We can no longer treat single-selector policies as wildcarding L3, as we
no longer have bpf datapath always performing policy enforcement before
cilium-envoy.

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
[ upstream commit d9c3afc ]

It's not required to validate traffic that is re-injected by the proxy
i.e. the original traffic was originally redirected to proxy, and then
came back.

With this change, there is more flexibility on setting the upstream
connection src IP from proxy.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
[ upstream commit 9394900 ]

During some other work I discovered that the whole active connection
tracking feature does not compile when enabled. Adding to the complexity
tests to add some compile coverage as regression test. Will fix the
actual issue in a subsequent commit.

Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
[ upstream commit 7c27078 ]

When both IPv6 and active connection tracking are enabled, we are unable
to compile, resulting in the following error:

```
./lib/lb.h:1071:21: error: use of undeclared identifier 'ct_state'
```

This is because in `lb6_local` the name of the variable is `state` not
`ct_state`. This issue seems to have been here since the introduction
of the feature and was never caught due to a lack of testing.

Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
[ upstream commit 9938f52 ]

The Cilium Operator logs are filled with attempts to retry updating
taints/conditions on nodes even if we can't get the node from the local
store due to node deletion. Skip retry in this case.

Signed-off-by: jshr-w <shjayaraman@microsoft.com>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau nbusseneau added kind/backports This PR provides functionality previously merged into master. backport/1.17 This PR represents a backport for Cilium 1.17.x of a PR that was merged to main. labels May 15, 2025
@nbusseneau nbusseneau marked this pull request as ready for review May 15, 2025 20:53
@nbusseneau nbusseneau requested a review from a team as a code owner May 15, 2025 20:53
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and looks good for my commit.

@nbusseneau
Copy link
Member Author

/test

Copy link
Member

@HadrienPatte HadrienPatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbusseneau nbusseneau added this pull request to the merge queue May 19, 2025
Merged via the queue into v1.17 with commit 26bd478 May 19, 2025
316 of 337 checks passed
@nbusseneau nbusseneau deleted the pr/v1.17-backport-2025-05-15-06-38 branch May 19, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.17 This PR represents a backport for Cilium 1.17.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants