-
Notifications
You must be signed in to change notification settings - Fork 3.4k
workflows: Add WireGuard in the Conformance Multi-Pool workflow #39561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/ci-multi-pool |
For context, I think #35895 demonstrates nicely why things work for Wireguard.
|
/ci-multi-pool |
Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
a5fcaff
to
bb1f56e
Compare
/ci-multi-pool |
Split off the tested multi-pool configurations into a separate file. This should make it easier to replace the configs, add additional files with custom configs and similar. It also harmonizes the workflow with how the IPsec upgrade and E2e upgrade workflows work. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
bb1f56e
to
9b87a24
Compare
/ci-multi-pool |
Artyop
approved these changes
May 20, 2025
/test |
This was referenced May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI
Continuous Integration testing issue or flake
area/multipool
Affects Multi-Pool IPAM
feature/wireguard
Relates to Cilium's Wireguard feature
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend Conformance Multi-Pool workflow to cover WireGuard based encryption, in both tunnel and direct routing mode.
Also, move the test configuration matrix in its own file, just like we do for Conformance IPsec E2E and Cilium E2E Upgrade workflows.
Differently from Conformance IPsec E2E and Cilium E2E Upgrade, despite testing the encryption feature, here we do not check for unencrypted packets. This is due to the fact that the bpftrace action we usually rely on to look for leaked packets is meant to run on a Little VM Helper Virtual Machine where the Kind cluster is installed and exposed. Since this is not the case for this workflow and in the long term the multi-pool IPAM config should be just another case in the matrix config of existing conformance tests, we simply skip that check here.
Example of a successful run: https://github.com/cilium/cilium/actions/runs/15122436433