Skip to content

bpf: host: flag Cilium's ESP traffic as TRACE_REASON_ENCRYPTED #39558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

bpf: host: flag Cilium's ESP traffic as TRACE_REASON_ENCRYPTED #39558

merged 1 commit into from
May 19, 2025

Conversation

julianwiedmann
Copy link
Member

Match what we do for Cilium's Wireguard traffic that passes through the to-netdev program on a native device.

Also clean up some whitespace damage while at it.

@julianwiedmann julianwiedmann requested a review from a team as a code owner May 15, 2025 14:33
@julianwiedmann julianwiedmann added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. release-note/misc This PR makes changes that have no direct user impact. feature/ipsec Relates to Cilium's IPsec feature labels May 15, 2025
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann
bpf: host: flag Cilium's ESP traffic as TRACE_REASON_ENCRYPTED
b65bfca 
Match what we do for Cilium's Wireguard traffic that passes through
the to-netdev program on a native device.

Also clean up some whitespace damage while at it.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann force-pushed the 1.18-bpf-ipsec-trace branch from e5cc8e2 to b65bfca Compare May 15, 2025 14:55
@julianwiedmann
Copy link
Member Author

/test

smagnani96
smagnani96 approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor

@smagnani96 smagnani96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, aligns to the WG codepath.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 19, 2025
@julianwiedmann julianwiedmann added this pull request to the merge queue May 19, 2025
Merged via the queue into cilium:main with commit 603d505 May 19, 2025
66 checks passed
@julianwiedmann julianwiedmann deleted the 1.18-bpf-ipsec-trace branch May 19, 2025 14:35
@julianwiedmann julianwiedmann added the needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch label May 22, 2025
@joamaki joamaki mentioned this pull request May 23, 2025
Merged
6 tasks
@joamaki joamaki added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels May 23, 2025
@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. labels May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldelossa ldelossa ldelossa approved these changes

@smagnani96 smagnani96 smagnani96 approved these changes

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. feature/ipsec Relates to Cilium's IPsec feature ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julianwiedmann @ldelossa @smagnani96 @joamaki