test/runtime: replace RuntimeAgentFQDNPolicies CNAME follow by unit test #39555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a unit test covering following of CNAMEs and respective minimum TTL values. This essentially captures the core of what the existing RuntimeAgentFQDNPolicies CNAME follow test is doing and will allow to remove said test in a successive commit. Signed-off-by: Tobias Klauser <tobias@cilium.io>
The same underlying functionality is covered in a unit test added in the precending commit. Remove the runtime test case. Signed-off-by: Tobias Klauser <tobias@cilium.io>
|
/test |
squeed
approved these changes
May 15, 2025
Artyop
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the CNAME follow test in the runtime FQDN suite by a unit test exercising the core of what the existing runtime test is about. This has a lot less overhead and is one step closer to getting rid of the runtime FQDN tests.
For #37838