Skip to content

policy: remove unused (*rule).resolve{In,E}gressPolicy return value #39554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

policy: remove unused (*rule).resolve{In,E}gressPolicy return value #39554

merged 1 commit into from
May 15, 2025

Conversation

tklauser
Copy link
Member

Only the error return value is used. The L4PolicyMap return value is unused since commit 3769727 ("policy: remove SearchContext (misc files)").

@tklauser
policy: remove unused (*rule).resolve{In,E}gressPolicy return value
e7b9f2f 
Only the error return value is used. The L4PolicyMap return value is
unused since commit 3769727 ("policy: remove SearchContext (misc
files)").

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser requested a review from squeed May 15, 2025 12:14
@tklauser tklauser requested a review from a team as a code owner May 15, 2025 12:14
@tklauser tklauser added kind/cleanup This includes no functional changes. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. release-note/misc This PR makes changes that have no direct user impact. labels May 15, 2025
@tklauser
Copy link
Member Author

/test

@tklauser tklauser enabled auto-merge May 15, 2025 12:14
squeed
squeed approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@squeed squeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has always annoyed me. nice!

@tklauser tklauser added this pull request to the merge queue May 15, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 15, 2025
Merged via the queue into main with commit 85e89d0 May 15, 2025
286 of 287 checks passed
@tklauser tklauser deleted the pr/tklauser/policy-unused-ret-val branch May 15, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tklauser @squeed