Skip to content

pkg/lb: Add service.node.io/node(-selector) support #39551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025

Conversation

brb
Copy link
Member

@brb brb commented May 15, 2025

See commit msgs.

@brb brb added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/loadbalancing Impacts load-balancing and Kubernetes service implementations labels May 15, 2025
@brb brb force-pushed the pr/brb/exp-lb-svc-node-exposure-v2 branch 2 times, most recently from 92db168 to 095ff33 Compare May 15, 2025 09:08
brb added 3 commits May 15, 2025 11:18
So that it can be reused by the exp/LB.

Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
Instead of k8s.Service. Again, helps with reusing it in exp/LB.

Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
The idea is that at the service conversion time we check whether a
current node's label (retrieved from the local node store) match the
selector. If not, then the conversion won't create any
*loadbalancer.{Service,[]FrontendParams}. Then this indicates that the
service should be not provisioned.

The implementation does not react to the node label changes. This
limitation exists in the legacy implementation too. In order to
provision services after the label change, a user needs to update all
relevant services (kubectl apply).

Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
@brb brb force-pushed the pr/brb/exp-lb-svc-node-exposure-v2 branch from 095ff33 to e4c2cee Compare May 15, 2025 09:18
@brb
Copy link
Member Author

brb commented May 15, 2025

/ci-integration

@brb brb marked this pull request as ready for review May 15, 2025 09:56
@brb brb requested review from a team as code owners May 15, 2025 09:56
@brb brb requested review from dylandreimerink and joamaki May 15, 2025 09:56
@brb
Copy link
Member Author

brb commented May 15, 2025

/test

@brb brb added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit 357f4fc May 15, 2025
350 of 355 checks passed
@brb brb deleted the pr/brb/exp-lb-svc-node-exposure-v2 branch May 15, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/loadbalancing Impacts load-balancing and Kubernetes service implementations release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants