probes: remove bpftool dependency
#39438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7782aa to
41b6285
Compare
|
/test |
rgo3
approved these changes
May 8, 2025
borkmann
reviewed
May 8, 2025
ee5aa2c to
acf40fc
Compare
|
@borkmann PTAL just in case. If tcx is enabled on the agent, we'll require tcx, otherwise we require tc-bpf. |
|
/test |
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
CONFIG_BPF is theoretically used to enable the legacy BPF interpreter, but it is rarely and inconsistently used throughout the Linux kernel. CONFIG_BPF_SYSCALL has it as a dependency, so let's only probe for that one instead. Replace the CONFIG_BPF_SYSCALL kconfig check with a 'real' syscall probe. Signed-off-by: Timo Beckers <timo@isovalent.com>
BPF_JIT and HAVE_EBPF_JIT both need to be enabled for the JIT to work. Replace the kconfig check with a real bpf()-based probe. Signed-off-by: Timo Beckers <timo@isovalent.com>
…/CLS_BPF Replace with a netlink-based probe. Signed-off-by: Timo Beckers <timo@isovalent.com>
This commit removes the leftover bits of bpftool-based kconfig parsing after being mostly replaced with bpf() and netlink-based feature probes in prior commits. This commit also removes the concept of 'optional' dependencies since they were relatively hidden in the log and have been rotting for several years. With this, the ProbeManager has been sunset. - Cgroups: used for socketlb, will throw an error anyway when the user tries to enable and cgroup-bpf support is compiled out - Events: unused by Cilium, though external tools like pwru rely on it for troubleshooting. Let this be documented by those external tools instead. - LWTunnel: unused by Cilium Signed-off-by: Timo Beckers <timo@isovalent.com>
acf40fc to
1e8235f
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces bpftool-based feature detection with real bpf() and netlink-based feature probes. It also removes the concept of 'optional' dependencies since they were relatively hidden in the log and have been rotting for several years.
With this, the ProbeManager has been sunset.
to enable and cgroup-bpf support is compiled out
troubleshooting. Let this be documented by those external tools instead.
Contributes towards: #38979
Fixes: #22514