endpoint: execute Endpoint.writeHeaderFile under lockAlive #39429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In af09899, the call to Endpoint.writeHeaderFile was moved out of preCompilationSteps since EndpointHash takes out a read lock, which didn't work since regenerateBPF is already run under a write lock. This patch puts writeHeaderFile under the endpoint lock once again. Fixes: cilium#38324 Signed-off-by: Timo Beckers <timo@isovalent.com>
|
/test |
|
@ti-mo From what I can tell this breakage never actually made it into a release, right? Adjusting the release-note accordingly. |
Indeed, wasn't sure how to go about it since a label was required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In af09899, the call to Endpoint.writeHeaderFile was moved out of preCompilationSteps since EndpointHash takes out a read lock, which didn't work since regenerateBPF is already run under a write lock.
This patch puts writeHeaderFile under the endpoint lock once again.
Fixes: #38324