Skip to content

loadbalancer: use netip.Prefix for Service.SourceRanges #39427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented May 8, 2025

There are no users requiring this to be a cidr.CIDR. Avoid unnecessary conversion to netip.Prefix for UpdateSourceRange by storing as netip.Prefix right away.

For #24246

There are no users requiring this to be a cidr.CIDR. Avoid unnecessary
conversion to netip.Prefix for UpdateSourceRange by storing as
netip.Prefix right away.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser requested a review from joamaki May 8, 2025 09:24
@tklauser tklauser requested a review from a team as a code owner May 8, 2025 09:24
@tklauser tklauser added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels May 8, 2025
@tklauser tklauser enabled auto-merge May 8, 2025 09:24
@tklauser
Copy link
Member Author

tklauser commented May 8, 2025

/test

Copy link
Contributor

@joamaki joamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Puzzled why I did it this way to begin with...

@tklauser tklauser added this pull request to the merge queue May 9, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 9, 2025
Merged via the queue into main with commit cf70fbd May 9, 2025
401 of 404 checks passed
@tklauser tklauser deleted the pr/tklauser/loadbalancer-source-ranges-netip branch May 9, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants