Skip to content

test/helpers: remove unused helpers #39426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

test/helpers: remove unused helpers #39426

merged 1 commit into from
May 8, 2025

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented May 8, 2025

The last remaining users of these helpers were removed in commit c81d39b ("test/runtime: Remove kvstore runtime tests" and commit f323ffc ("kvstore: Remove Consul support"), respectively.

@tklauser
test/helpers: remove unused helpers
ba3cb02 
The last remaining users of these helpers were removed in commit
c81d39b ("test/runtime: Remove kvstore runtime tests" and commit
f323ffc ("kvstore: Remove Consul support"), respectively.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser requested a review from a team as a code owner May 8, 2025 09:16
@tklauser tklauser added area/CI Continuous Integration testing issue or flake kind/cleanup This includes no functional changes. labels May 8, 2025
@tklauser tklauser requested a review from christarazi May 8, 2025 09:16
@tklauser tklauser added the release-note/ci This PR makes changes to the CI. label May 8, 2025
@tklauser
Copy link
Member Author

tklauser commented May 8, 2025

/test

@tklauser tklauser enabled auto-merge May 8, 2025 09:16
@tklauser tklauser mentioned this pull request May 8, 2025
Closed
@tklauser
Copy link
Member Author

tklauser commented May 8, 2025 •
edited
Loading

/ci-integration

Filed #39428 for the flake.

@tklauser tklauser added this pull request to the merge queue May 8, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 8, 2025
Merged via the queue into main with commit c3040c5 May 8, 2025
168 of 173 checks passed
@tklauser tklauser deleted the pr/tklauser/runtime-test-cleanup branch May 8, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tklauser @christarazi