Skip to content

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented May 8, 2025

Relates: #38224

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 8, 2025
@sayboras sayboras added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label May 8, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 8, 2025
@sayboras sayboras force-pushed the pr/tammach/proxylib-warn branch from fc65c4e to bc3b61a Compare May 8, 2025 05:28
@sayboras
Copy link
Member Author

sayboras commented May 8, 2025

/test

@sayboras sayboras force-pushed the pr/tammach/proxylib-warn branch from bc3b61a to 7ac6ec2 Compare May 8, 2025 10:06
@sayboras
Copy link
Member Author

sayboras commented May 8, 2025

/test

@sayboras sayboras force-pushed the pr/tammach/proxylib-warn branch from 7ac6ec2 to 4336041 Compare May 19, 2025 12:09
@sayboras
Copy link
Member Author

/test

@sayboras sayboras marked this pull request as ready for review May 19, 2025 13:30
@sayboras sayboras requested review from a team as code owners May 19, 2025 13:30
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the logs; there's at least the Slack URL to fix.

@qmonnet qmonnet requested a review from xmulligan May 19, 2025 14:01
@sayboras sayboras force-pushed the pr/tammach/proxylib-warn branch from 4336041 to fe0e3b1 Compare May 21, 2025 06:53
@sayboras sayboras requested review from mhofstetter and qmonnet May 21, 2025 06:53
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once Marco's comment has been addressed, thanks!

Relates: #38224
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/proxylib-warn branch from fe0e3b1 to 14fadb8 Compare May 21, 2025 11:12
@sayboras
Copy link
Member Author

/test

@sayboras sayboras enabled auto-merge May 21, 2025 11:25
@sayboras sayboras added this pull request to the merge queue May 21, 2025
Merged via the queue into main with commit 5a1010a May 21, 2025
286 checks passed
@sayboras sayboras deleted the pr/tammach/proxylib-warn branch May 21, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants