bpf,nodeport: Fix broken nodeport_nat_egress_ipv4_hook #39418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a939356 to
9801fcf
Compare
nodeport_nat_egress_ipv4_hook and nodeport_rev_dnat_ipv4_hook is defined as a macro and we substitute it to the constant value. This kills the compile-time check for the input value entirely. The input value is not type-checked or we can even use the undeclared variable like the bug in the previous commit. To avoid such a mistake. Evaluate the input value properly. The following is an example for detecting the error in the previous commit. ``` ./lib/nodeport.h:2488:48: error: use of undeclared identifier 'info' 2488 | ret = nodeport_nat_egress_ipv4_hook(ctx, ip4, info->sec_identity, &tuple, l4_off, &ext_err); ``` Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
9801fcf to
3e34931
Compare
|
/test |
|
Seems reasonable to me, but let's wait for Paul to take a look in case the revert would expose some other issue. /cc @pchaigno |
pchaigno
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 3c4693f, the nodeport_nat_egress_ipv4_hook is broken because it passes the undefined variable in the non-tunnel mode. This PR fixes it and adds an extra validation for the input values for preventing the future bug. If we cannot agree with the prevention, I can drop the second commit.
Fixes: #39074