test/controlplane: Remove load-balancing test cases #39494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pkg/loadbalancer/tests does the same tests, but in a much more maintainable way. Signed-off-by: Jussi Maki <jussi@isovalent.com>
|
/test |
christarazi
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pkg/loadbalancer/tests does the same tests, but in a much more maintainable way.
Last remaining test in test/controlplane is the CiliumNode test that checks that the agent will create the CiliumNode object from a Node object (e.g. exercising the pkg/nodediscovery). If we'd move
daemon/cmd/local_node_sync.goto e.g. pkg/node or pkg/nodediscovery, then we could implement a script test inpkg/nodediscoveryand remove test/controlplane completely (d2c87be attempted this but is missing the "local node sync" part). Though likely it makes sense to wait for theTable[Node]PR to land before doing this as it would make his much easier.