agent: Remove service monitor notifications #39493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
approved these changes
May 12, 2025
|
/test |
The service notifications are being removed so mark them as deprecated in the protobuf. Signed-off-by: Jussi Maki <jussi@isovalent.com>
The service notifications were not used by Hubble and they are now being removed from the monitor agent. Signed-off-by: Jussi Maki <jussi@isovalent.com>
The service monitor notifications are being removed so drop the use of them from the legacy code. Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
4679db8 to
83e8fee
Compare
kaworu
approved these changes
May 12, 2025
kaworu
reviewed
May 12, 2025
|
/test |
YutaroHayakawa
approved these changes
May 15, 2025
glrf
approved these changes
May 19, 2025
glibsm
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service monitor notifications were shown as part of
cilium-dbg monitorand emitted towards Hubble. Hubble never used this functionality and there were incidents due to the extra memory used for storing the service notifications in the Hubble ring buffer (#36391, #36394). With the new load-balancing implementation we can replace the service notifications incilium-dbg monitorwithcilium-dbg shell -- db/watch frontendswhich not only gives more information, but avoids the cost of converting to the service notification and storing it in the monitor ring buffer.Thus, this PR marks the service notifications in the Hubble protobufs as deprecated and deletes the notifications from the monitor API along with their use in the code.