workflows, docs: Remove useless echo in IPsec key rotation command
#39492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martynas noted more than a year ago that the echo command in our key rotation oneliner is useless, but we never got around to actually remove it. Maciej is about to make that change to pass a new GitHub action linter. This commit carries that change and makes sure the same oneliner is used in the documentation and in the CI. Suggested-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
|
/test |
Merged
viktor-kurchenko
approved these changes
May 12, 2025
qmonnet
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Martynas noted more than a year ago that the
echocommand in our key rotation oneliner is useless, but we never got around to actually remove it. Maciej is about to make that change to pass a new GitHub action linter. This commit carries that change and makes sure the same oneliner is used in the documentation and in the CI.