policy: Remove Redundant Dualstack Identity Insertion #39471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With 516612b the "world" entity-label automatically encompasses the "world-ipv4" and "world-ipv6" labels. These are automatically inserted into mapstate because of their association with the world label, regardless of whether Cilium is in dual-stack mode. This code is a no-op and can be removed. The distillery tests continued success shows that this code removal does not matter (see `Test_EnsureDeniesPrecedeAllows`, for world label <-> identity test examples). Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
|
/test |
bimmlerd
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #29958 the "world" entity-label automatically
encompasses the "world-ipv4" and "world-ipv6" labels.
These are automatically inserted into mapstate because
of their association with the world label, regardless
of whether Cilium is in dual-stack mode. This code is
a no-op and can be removed. The distillery tests
continued success shows that this code removal does
not matter (see
Test_EnsureDeniesPrecedeAllows,for world label <-> identity test examples).
Fixes: #22625