pkg/ipcache: migrate to slog #39463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

julianwiedmann merged 1 commit into main from pr/move-ipcache-to-slog

May 14, 2025

Member

aanm commented May 9, 2025

Migrate this package to use slog instead of logrus.

aanm added area/misc release-note/misc feature/slog labels

Member Author

aanm commented May 9, 2025

/test

aanm force-pushed the pr/move-ipcache-to-slog branch from feed079 to d5bf1b3 Compare

May 9, 2025 15:19

Member Author

aanm commented May 9, 2025

/test

aanm marked this pull request as ready for review

May 9, 2025 15:42

aanm requested review from a team as code owners

May 9, 2025 15:42

aanm requested review from smagnani96, bimmlerd, tklauser and giorio94

May 9, 2025 15:42

aanm enabled auto-merge

May 9, 2025 15:42

giorio94 approved these changes

View reviewed changes

Member

giorio94 left a comment

/lgtm for my codeowners

bimmlerd reviewed

View reviewed changes

pkg/ipcache/types.go Show resolved Hide resolved

pkg/ipcache/types.go Show resolved Hide resolved

pkg/ipcache/kvstore.go Show resolved Hide resolved

pkg/ipcache/ipcache.go Show resolved Hide resolved

smagnani96 approved these changes

View reviewed changes

Contributor

smagnani96 left a comment

LGTM 👍🏼


          pkg/ipcache: migrate to slog

745ede5

Migrate this package to use slog instead of logrus.

Signed-off-by: André Martins <andre@cilium.io>

aanm force-pushed the pr/move-ipcache-to-slog branch from d5bf1b3 to 745ede5 Compare

May 12, 2025 09:57

Member Author

aanm commented May 12, 2025

/test

bimmlerd approved these changes

View reviewed changes

tklauser approved these changes

View reviewed changes

aanm added this pull request to the merge queue

maintainer-s-little-helper bot added the ready-to-merge label

github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch

aanm added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch

aanm added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

aanm added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

aanm added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

aanm added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

aanm added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

aanm added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

julianwiedmann added this pull request to the merge queue

Merged via the queue into main with commit 729ef46

328 of 332 checks passed

julianwiedmann deleted the pr/move-ipcache-to-slog branch

May 14, 2025 03:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/misc feature/slog ready-to-merge release-note/misc