identity/ipcache: extract identity restoration logic from Daemon #39456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93f4423 to
a1510ed
Compare
Currently, the functionality that restores the local identities is part of the daemon and is placed in package `daemon/cmd`. To eventually delete the legacy daemon logic, this commit extracts this logic (and state about restored identities) into its own Go struct (including Hive Cell) `LocalIdentityRestorer`. While this commit extracts the logic, the lifecycle is still controlled by the daemon init logic (by calling the respective methods on the restorer). Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
…oration This comit moves the extracted identity restorer from package `daemon/cmd` to `pkg/identity/restoration`. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This commit migrates the identity restorer to use a Hive injected slog logger instead of the package scoped logrus instance. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
a1510ed to
3b5cc40
Compare
|
/test |
bimmlerd
approved these changes
May 14, 2025
squeed
reviewed
May 15, 2025
squeed
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the local identity restoration logic and state from the Daemon.
Please review the individual commits.