ci: add actionlint #39455
Merged
ci: add actionlint #39455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b536b18 to
7749809
Compare
|
/test |
pchaigno
reviewed
May 12, 2025
pchaigno
approved these changes
May 12, 2025
viktor-kurchenko
approved these changes
May 13, 2025
liyihuang
approved these changes
May 13, 2025
thorn3r
approved these changes
May 13, 2025
9f68e9e to
666e477
Compare
|
/test |
|
rebased due to conflicts |
youngnick
approved these changes
May 14, 2025
666e477 to
5f10242
Compare
|
/test |
doniacld
approved these changes
May 15, 2025
doniacld
reviewed
May 15, 2025
rationale for shellcheck ignores: - SC2086 there was a lot of offenders and this change would need to be even bigger, we might want to revisit fixing that. - SC2129 stylistic issue, not worth fixing. - SC2185 these workflows are already running on Linux and are unlikely to be run on other platforms. If we ever need to fix it, let's do it then. - SC2162 we are using read only in pipes, not worth fixing. - SC2090, SC2089 we store a lot of Cilium options in GITHUB_OUTPUT as strings that will be used with backslashes, this is so prevalent that I opted for general exception instead of putting disable comments in many files. - SC2001 personal preference, I would rather pipe to sed instead of using builtin search/replace. - SC2002 personal preference, doesn't really introduce any bugs and it would make the overall change bigger. Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
5f10242 to
b6266ad
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rationale for shellcheck ignores:
even bigger, we might want to revisit fixing that.
to be run on other platforms. If we ever need to fix it, let's do it
then.
strings that will be used with backslashes, this is so prevalent that
I opted for general exception instead of putting disable comments in
many files.
using builtin search/replace.
would make the overall change bigger.