-
Notifications
You must be signed in to change notification settings - Fork 3.4k
test: Remove vagrant VM provisioning #39450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test |
145be76
to
8327b81
Compare
/test |
8327b81
to
1adb0f1
Compare
The vagrant artifacts necessary to provision the VM from scratch was removed in commit bafb49b ("cleanup: Remove vagrant related file"). Remove the -cilium.reprovision flag and corresponding logic which is now broken and unusable. Signed-off-by: Joe Stringer <joe@cilium.io>
Commit 2bd2a36 ("ginkgo: Remove Tests with secondary NodePort device") removed the tests that were using these variables. Clean up the remaining code. Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Joe Stringer <joe@cilium.io>
1adb0f1
to
654f2c5
Compare
/test |
julianwiedmann
approved these changes
May 20, 2025
bimmlerd
approved these changes
May 20, 2025
Artyop
approved these changes
May 20, 2025
Hit a disk space issue in the merge queue. Hopefully this should fix it: #39644 |
YutaroHayakawa
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release-note/ci
This PR makes changes to the CI.
sig/policy
Impacts whether traffic is allowed or denied based on user-defined policies.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove most of the remaining references to Vagrant in the test/ directory,
including the logic to provision VMs and make targets that refer to that test
environment.