Skip to content

test: Remove vagrant VM provisioning #39450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2025
Merged

test: Remove vagrant VM provisioning #39450

merged 3 commits into from
May 20, 2025

Conversation

joestringer
Copy link
Member

Remove most of the remaining references to Vagrant in the test/ directory,
including the logic to provision VMs and make targets that refer to that test
environment.

@joestringer joestringer added the release-note/ci This PR makes changes to the CI. label May 9, 2025
@github-actions github-actions bot added the sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. label May 9, 2025
@joestringer
Copy link
Member Author

/test

@joestringer joestringer force-pushed the pr/joe/clean-vagrant branch from 145be76 to 8327b81 Compare May 9, 2025 06:52
@joestringer
Copy link
Member Author

/test

@joestringer joestringer force-pushed the pr/joe/clean-vagrant branch from 8327b81 to 1adb0f1 Compare May 13, 2025 21:57
@joestringer joestringer reopened this May 13, 2025
The vagrant artifacts necessary to provision the VM from scratch was
removed in commit bafb49b ("cleanup: Remove vagrant related file").
Remove the -cilium.reprovision flag and corresponding logic which is now
broken and unusable.

Signed-off-by: Joe Stringer <joe@cilium.io>
Commit 2bd2a36 ("ginkgo: Remove Tests with secondary NodePort device")
removed the tests that were using these variables. Clean up the
remaining code.

Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer force-pushed the pr/joe/clean-vagrant branch from 1adb0f1 to 654f2c5 Compare May 13, 2025 22:34
@joestringer
Copy link
Member Author

/test

@joestringer joestringer marked this pull request as ready for review May 19, 2025 18:30
@joestringer joestringer requested review from a team as code owners May 19, 2025 18:30
@joestringer joestringer added this pull request to the merge queue May 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2025
@joestringer joestringer added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 20, 2025
@joestringer
Copy link
Member Author

Hit a disk space issue in the merge queue. Hopefully this should fix it: #39644

@maintainer-s-little-helper maintainer-s-little-helper bot removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 20, 2025
@joestringer joestringer added this pull request to the merge queue May 20, 2025
Merged via the queue into main with commit 19f5813 May 20, 2025
300 checks passed
@joestringer joestringer deleted the pr/joe/clean-vagrant branch May 20, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ci This PR makes changes to the CI. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants