pkg/k8s: Synchronize heartbeat goroutine #39448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
389079f to
2b57a06
Compare
|
/test |
2b57a06 to
8f6fc4b
Compare
|
/test |
|
Ran all the tests in the file 100 times locally without any issue. |
marseel
requested changes
May 12, 2025
FYI, I've ran your patch with that |
8f6fc4b to
4e1b907
Compare
|
/test |
marseel
approved these changes
May 13, 2025
|
Added the |
The test cases exercise timing aspects so set a higher limit to avoid spurious failures. This fixes the flakes seen in CI. Suggested-by: Marcel Zieba <marcel.zieba@isovalent.com> Signed-off-by: Aditi Ghag <aditi@cilium.io>
4e1b907 to
cf23fed
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the heartbeat timeout is set to a low value (e.g., in tests), there's a risk that the goroutine responsible for sending heartbeat probes may not start before the timeout expires. To address this, introduce a channel to synchronize goroutine startup.
A WaitGroup could also be used, but it risks blocking the controller indefinitely if the goroutine fails to start or blocks on I/O.
Fixes: #39428