ci: do not run north-south conn disrupt for 5.4 kernel #39443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
nbusseneau
reviewed
May 13, 2025
|
I'd like to merge this along with the new CLI version once it's released, so we know that it actually works. Let's please park the change until then? :) |
1e3cf10 to
dd1bb4b
Compare
nbusseneau
approved these changes
May 14, 2025
dd1bb4b to
897568d
Compare
Upstream cilium CLI now runs north-south conn disruptions more liberally. This was made possible by EoL'ing the 5.4 kernel tests. However, stable branches will still test 5.4 kernel. Therefore, we need to ensure north-south conn disrupt tests do not run for stable branches which still place the 5.4 kernel under test. Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com>
897568d to
4fd2139
Compare
|
/test |
smagnani96
added a commit
that referenced
this pull request
Jul 9, 2025
This commit updates the e2e-upgrade and ipsec-upgrade workflows to not run the north-south connection disruption test on 5.4 kernel when downgrading Cilium version. In #39443 we introduced the fix, using a `kernel` variable that will be sanitized and compared against version "5.4" to skip the test. This commit completes the fix by adding the check also when downgrading Cilium, otherwise the flake "FIB lookup failed" would still happen in the downgrade case. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 9, 2025
This commit updates the e2e-upgrade and ipsec-upgrade workflows to not run the north-south connection disruption test on 5.4 kernel when downgrading Cilium version. In #39443 we introduced the fix, using a `kernel` variable that will be sanitized and compared against version "5.4" to skip the test. This commit completes the fix by adding the check also when downgrading Cilium, otherwise the flake "FIB lookup failed" would still happen in the downgrade case. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream cilium CLI now runs north-south conn disruptions more liberally.
This was made possible by EoL'ing the 5.4 kernel tests.
However, stable branches will still test 5.4 kernel.
Therefore, we need to ensure north-south conn disrupt tests do not run for stable branches which still place the 5.4 kernel under test.