Skip to content

cli: Move unexpected packet drops to final test #39334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

cli: Move unexpected packet drops to final test #39334

merged 1 commit into from
May 6, 2025

Conversation

nebril
Copy link
Member

@nebril nebril commented May 5, 2025

This change ensures that noUnexpectedPacketDrops is running after all other tests that might be a source of unexpected drop.

@nebril
cli: Move unexpected packet drops to final test
90f98fc 
This change ensures that noUnexpectedPacketDrops is running after all
other tests that might be a source of unexpected drop.

Signed-off-by: Maciej Kwiek <mkwiek@cisco.com>
@nebril nebril requested a review from a team as a code owner May 5, 2025 12:20
@nebril nebril requested a review from christarazi May 5, 2025 12:20
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 5, 2025
@nebril nebril requested a review from viktor-kurchenko May 5, 2025 12:20
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels May 5, 2025
@nebril nebril added release-note/misc This PR makes changes that have no direct user impact. and removed cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels May 5, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 5, 2025
@nebril nebril enabled auto-merge May 5, 2025 14:20
@julianwiedmann julianwiedmann added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels May 5, 2025
@julianwiedmann
Copy link
Member

/test

@julianwiedmann
Copy link
Member

There's some subtlety here - as the names of the finalTests don't match the seq-* filter for sequential tests, they don't actually run as part of the sequential set of tests. But only much later, once the concurrent set of tests has completed.

Ideally we'd be running the finalTests after each set of tests.

@nebril nebril added this pull request to the merge queue May 6, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 6, 2025
Merged via the queue into cilium:main with commit 92b0f16 May 6, 2025
74 checks passed
@nebril nebril deleted the pr/nebril/no-unexpected-drop-final branch May 6, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nebril @julianwiedmann @christarazi @viktor-kurchenko