Release IPPrefixes: Support AWS ENI IP Prefix unassignment #39300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doniacld
reviewed
May 5, 2025
doniacld
reviewed
May 5, 2025
PavelGloba
reviewed
May 5, 2025
62d67c2 to
5580b40
Compare
|
Commit c72021a does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
c72021a to
8f41fb5
Compare
|
This needs an ACK from alibabacloud and azure |
christarazi
approved these changes
Jul 2, 2025
auto-merge was automatically disabled
July 3, 2025 02:11
Head branch was pushed to by a user without write access
|
Commit b49935c does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
b49935c to
3e8b7e2
Compare
|
/test |
tamilmani1989
approved these changes
Jul 3, 2025
|
Please rebase your PR against the tip of the |
3e8b7e2 to
05bf3fa
Compare
|
/test |
Cilium currently does not support releasing IPPrefixes and secondary IPs when IPPrefix delegation enabled due to which IP starvation is happening in our Kubernetes clusters. We have to manually delete a node in order to free unused IPPrefixes. With this fix, the operator will release those unused IPPrefixes and secondary IPs to reassign them again in AWS ENI. Added a no-op stub implementation in Alibaba and Azure Clouds to satisfy the NodeOperations interface. Fixes: cilium#32209, cilium#39904 Signed-off-by: Harish Salluri <hsalluri259@gmail.com>
05bf3fa to
342f32c
Compare
|
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cilium currently do not support releasing IPPrefixes due to which IP starvation is happening in our Kubernetes clusters. We have to manually delete a node in order to free unused IPPrefixes. With this fix, operator will release those unused IPPrefixes to reassign them again in AWS ENI. Added no-op stub implementation in azure and alibabacloud to satisfy NodeOperations interface.
Fixes: #32209, #39904
Without this fix, delegated prefixes won’t be released until their nodes are deleted, resulting in wasted IP space.
With the fix in place, IP Prefixes are released and can be reused again.
Non goals :