Miscellaneous improvements to the clustermesh scale test #39397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
|
/scale-clustermesh |
christarazi
approved these changes
May 7, 2025
Use the helm-default action to retrieve the default helm settings to reduce duplication and ensure consistency with the other workflows. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Replace the bespoke logic with the dedicated action, to ensure consistency with the other workflows. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Drop the SHA variable, and replace the only remaining usage with the spelled out version, for additional clarity and consistency with all other usages. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
cdd58ee to
0298f1f
Compare
|
Rebased to make the workflow lint job happy again. |
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the individual commit messages for additional details.
Successful run: https://github.com/cilium/cilium/actions/runs/14888944751/job/41815931415