Skip to content

Conversation

gentoo-root
Copy link
Contributor

IPv6 fragments were implemented in #38110. Follow-up with some optimizations, aimed to reduce the verification complexity.

Optimize the implementation of IPv6 fragments.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 7, 2025
@gentoo-root gentoo-root added the release-note/misc This PR makes changes that have no direct user impact. label May 7, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 7, 2025
@gentoo-root gentoo-root added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 7, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 7, 2025
Extracting the call to ipv6_hdrlen_offset from lb6_extract_tuple allows
for optimizations based on squashing ipv6_hdrlen and ipv6_get_fraginfo.

Do the parallel change to lb4_extract_tuple.

Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
Both functions go over the IPv6 extension headers. To reduce verifier
complexity and CPU cycles, go over them once where easily possible
(where both functions are called together).

Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
@gentoo-root gentoo-root force-pushed the pr/max/ipv6-fragments-opt-v2 branch from 22e1b6d to 3bff8c0 Compare May 9, 2025 16:09
@gentoo-root
Copy link
Contributor Author

/test

@gentoo-root gentoo-root marked this pull request as ready for review May 9, 2025 18:35
@gentoo-root gentoo-root requested a review from a team as a code owner May 9, 2025 18:35
@gentoo-root gentoo-root requested a review from YutaroHayakawa May 9, 2025 18:35
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 9, 2025
@julianwiedmann
Copy link
Member

Nice one @gentoo-root 🚀

@julianwiedmann julianwiedmann added this pull request to the merge queue May 10, 2025
@julianwiedmann julianwiedmann added the kind/complexity-issue Relates to BPF complexity or program size issues label May 10, 2025
Merged via the queue into main with commit 9f8b2a9 May 10, 2025
360 of 363 checks passed
@julianwiedmann julianwiedmann deleted the pr/max/ipv6-fragments-opt-v2 branch May 10, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/complexity-issue Relates to BPF complexity or program size issues ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants